Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs for Android release builds aren't deobfuscated #59154

Open
narsaynorath opened this issue Jan 25, 2023 · 17 comments
Open

Breadcrumbs for Android release builds aren't deobfuscated #59154

narsaynorath opened this issue Jan 25, 2023 · 17 comments

Comments

@narsaynorath
Copy link
Member

Environment

SaaS (https://sentry.io/)

Version

No response

Link

https://sentry.io/organizations/sentry-sdks/issues/3885054835/events/c884e0bb85284cde9035b55d8ac567cc/?project=5428559&referrer=previous-event

DSN

No response

Steps to Reproduce

  1. Navigate to page
  2. Check the breadcrumbs section

Expected Result

Any values from the android application should be deobfuscated if there is a corresponding ProGuard file

Actual Result

The ui-click view.class values are still obfuscated, showing k.e

@narsaynorath
Copy link
Member Author

Just noticed this while looking into deobfuscating the view hierarchy

Screen Shot 2023-01-25 at 9 56 54 AM

@getsantry
Copy link
Contributor

getsantry bot commented Jan 30, 2023

Routing to @getsentry/team-mdx for triage, due by Wednesday, February 1st at 11:37 am (sfo). ⏲️

@hubertdeng123
Copy link
Member

Issue opened by a member of Sentry, doesn't need triaging

@timothyzeller
Copy link

Also experiencing the same issue as @narsaynorath

@adolfobulfoni-tomtom
Copy link

Having the same issue here on our project. 99% of entries for fragments state are not deobfuscated (except for 2 fragments who for weird reasons are deobfuscated). We are using manual FragmentLifecycleIntegration:

options.addIntegration(
                    FragmentLifecycleIntegration(
                        application,
                        enableFragmentLifecycleBreadcrumbs = true,
                        enableAutoFragmentLifecycleTracing = true
                    )
                )

see:
Screenshot 2023-10-31 at 15 48 43

@hubertdeng123 hubertdeng123 transferred this issue from getsentry/sentry Oct 31, 2023
@romtsn
Copy link
Member

romtsn commented Oct 31, 2023

@hubertdeng123 this should live on the main sentry repo, we cannot do anything from the SDK side here, this is backend stuff.

@hubertdeng123
Copy link
Member

@romtsn Got it. I was a bit confused by what's going on here since it seemed like the issue might've fallen through. I'll transfer it back.

@hubertdeng123 hubertdeng123 transferred this issue from getsentry/sentry-java Oct 31, 2023
@NemanjaBozovic-TomTom
Copy link

Any updates on this issue? It's hard to debug fragment events when we cannot see the names.
Thanks

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Jan 30, 2024
@hubertdeng123
Copy link
Member

Looks like this item is backlogged, so unlikely.

@vzukanov
Copy link

vzukanov commented Feb 8, 2024

This issue undermines the premise of lifecycle breadcrumbs. Would be great if Sentry team would allocate some effort towards its resolution.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Feb 8, 2024
@romtsn
Copy link
Member

romtsn commented Feb 8, 2024

there's some work going on to deobfuscate the entire event payload (breadcrumbs, messages, contexts, tags, etc etc) afaik, but no ETA. In the meantime you could exclude fragment names from deobfuscation (not great, I know)

@vzukanov
Copy link

vzukanov commented Feb 8, 2024

Good to know. Thanks for the update.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 2 Feb 9, 2024
@Angelodaniel
Copy link
Member

Hey Team,
Is there some progress on this?
Adding pro-guard rules is a patch which needs to be reverted once the real solution is in place, something we rather not spend time/effort on. It also would be great if these kinds of issues would be resolved asap as that would give us a higher confidence on using the product, as it shows that if we experience issues they are resolved timely.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Mar 26, 2024
@romtsn
Copy link
Member

romtsn commented Mar 27, 2024

Progress can be tracked in the symbolicator repo.

Just to give some details: proguard processing is currently one of the biggest bottlenecks in our system, and this feature is not as straightforward to implement as it seems, moving proguard processing to a separate service in rust (symbolicator) with lots of memory should enable us to deobfuscate the entire event payload much easier.

maybe @Swatinem or @loewenheim can chime in and give even more details on when this might become possible

@Swatinem
Copy link
Member

I would say we are in the final stretch to implement this for "regular" stack traces / frames, and profiles.
We haven’t really done any work yet to support a more generic way to deobfuscate "random class names", like what happens in view_hierarchy and also possibly breadcrumbs.

Once we have rolled this out for stack traces, we will look at extending this further as a followup.

@JustinBis
Copy link

Anything new here? Would also love to have this feature. We have a lot of custom breadcrumb logging that occasionally includes class names. Having this done automatically, or even some tag we could apply to a breadcrumb to opt it in to deobfuscation would be great.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 21, 2024
@romtsn
Copy link
Member

romtsn commented Nov 22, 2024

@JustinBis sadly no news, we'll update here when we get to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Status: No status
Status: Needs Discussion
Development

No branches or pull requests