Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions not getting marked as crashed #496

Open
gid-sentry opened this issue Feb 15, 2024 · 10 comments
Open

Sessions not getting marked as crashed #496

gid-sentry opened this issue Feb 15, 2024 · 10 comments
Labels
Bug Something isn't working

Comments

@gid-sentry
Copy link

Environment

How do you use Sentry?
Sentry SaaS (sentry.io)

Which version of the SDK? 0.15.1

How did you install the package? AssetStore

Steps to Reproduce

  1. Record a Session
  2. Crash it

Expected Result

Session appears in Sentry as crashed

Actual Result

Session appears in Sentry, but not as crashed. Crash makes it into Sentry though .

So I've tried setting this value Settings->EnableAutoSessionTracking = true; in USentrySettings . That didnt seem to do anythihng
And then I tried calling USentrySubsystem::StartSession();, which then does show up as a session in the dashboard. But then when I attempt to crash from that session, it still counts as successful. I made sure not to call USentrySubsystem::EndSession()
And then I tried "hack" the Sentry library code in SentrySubsystemDesktop::HandleBeforeSend code to call sentry_end_session_with_status with a crash status defined in sentry.h. This didnt seem to work either because I think HandleBeforeSend doesnt seem to be called..

@gid-sentry gid-sentry added Bug Something isn't working Platform: Unreal labels Feb 15, 2024
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Feb 15, 2024
@gid-sentry
Copy link
Author

Internal ticket here: https://getsentry.atlassian.net/browse/FEEDBACK-2108

@bruno-garcia
Copy link
Member

@tustanivsky any idea what might be happening?

@tustanivsky
Copy link
Collaborator

Is this something that happens in UE older than 5.2? If so, we can't enable crashpad there due to the engine's limitations, and thus, there's no way to mark a session as crashed when the error occurs.

@bruno-garcia
Copy link
Member

bruno-garcia commented Oct 17, 2024

@tustanivsky is that somewhere on our docs? If not, we should add it. Probably here: https://docs.sentry.io/platforms/unreal/configuration/releases/

@strangezakary
Copy link

Hi we are experiencing this issue as well. We are on Unreal 5.3 and are getting errors with crash_type: crash and we are still seeing 100% crash-free. We are using automatic session tracking, any ideas what to look at?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 13, 2024
@strangezakary
Copy link

strangezakary commented Nov 13, 2024

Looking more into this it doesn't look like sentry_end_session_with_status isnt called anywhere so how would it know if it crashed?

@tustanivsky
Copy link
Collaborator

@strangezakary Do you have Enable automatic crash capturing (Windows, UE 5.2+) option turned on in Sentry plugins settings?

@strangezakary
Copy link

@tustanivsky We do. I think the default is on

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 14, 2024
@strangezakary
Copy link

Actually it looks like we don't? Do we need this on?

@tustanivsky
Copy link
Collaborator

Yes, this has to be enabled. Basically, it allows you to utilize Sentry's native integration for capturing crashes instead of the engine's default error-handling mechanism and thus track session status properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Todo
Status: No status
Status: No status
Development

No branches or pull requests

5 participants