Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert filter unreal.crashtype not respected in alert rules #256

Open
rodolfoBee opened this issue Apr 11, 2023 · 11 comments
Open

Alert filter unreal.crashtype not respected in alert rules #256

rodolfoBee opened this issue Apr 11, 2023 · 11 comments
Labels
Bug Something isn't working

Comments

@rodolfoBee
Copy link
Member

Environment

SaaS (https://sentry.io/)

Version

No response

Link

No response

DSN

No response

Steps to Reproduce

1.Create a new alert with filter: The event's "unreal.crashtype" value "does not equal" "Ensure" so events that have this crash type do not trigger the alert.
2. Send an event to the project with unreal.crashtype=Ensure.

Example alert on test org: https://dev-curumas.sentry.io/alerts/rules/notjava/4430873/details/

Expected Result

Evens that contain Unreal.crash_type=Ensure in its additional context do NOT trigger the alert.

Actual Result

The alert is triggered.

At the start I suspected it was due to Minidump processing: the Unreal context is only added after applying DIFs to the event, but from what I see in the code, any event with the context should work.

So I sent a test event with a matching context (screenshot) and it triggered the alert.
Screenshot 2023-04-11 at 09 39 21

Unreal filter option was recently added here: getsentry/sentry#44021

In any case, this issue affects a paying customer, the specific information can be found in this internal ticket (not sharing due to possible PII). In the affected user's account there are unreal events with crash_type=Ensure that triggered the alert when the rule is set to trigger only when crash type is not equal to Ensure.

@getsantry
Copy link

getsantry bot commented Apr 11, 2023

Assigning to @getsentry/support for routing, due by Tuesday, April 11th at 5:00 pm (sfo). ⏲️

@getsantry
Copy link

getsantry bot commented Apr 11, 2023

Routing to @getsentry/issue-experience for triage, due by Wednesday, April 12th at 5:00 pm (sfo). ⏲️

@getsantry
Copy link

getsantry bot commented Apr 11, 2023

Routing to @getsentry/team-mobile for triage, due by Wednesday, April 12th at 5:00 pm (sfo). ⏲️

@brianthi
Copy link

Reassigning to the mobile team since this particular filter was added by them recently.

@markushi markushi transferred this issue from getsentry/sentry Apr 15, 2023
@romtsn
Copy link
Member

romtsn commented Apr 15, 2023

@bitsandfoxes would you mind looking into this, since you've implemented the feature? thanks

@philipphofmann
Copy link
Member

philipphofmann commented Apr 17, 2023

@romtsn, @bitsandfoxes is on PTO and will be back on April 24th.

@bitsandfoxes
Copy link
Contributor

@rodolfoBee @romtsn On it.

@suyashFSG
Copy link

Started using Sentry's Unreal integration recently and I have been running into exact same issue. Support forwarded me link to this issue. Would love to see this resolved so that I can properly configure Sentry alerts to only be sent for crashes and asserts and not for ensures

@bitsandfoxes
Copy link
Contributor

@suyashFSG Thanks for reaching out. Yes, we'll revisit this.

@bitsandfoxes bitsandfoxes mentioned this issue Jun 13, 2023
12 tasks
@bitsandfoxes bitsandfoxes added this to GDX Mar 4, 2024
@bitsandfoxes bitsandfoxes self-assigned this Mar 11, 2024
@bitsandfoxes bitsandfoxes removed their assignment Apr 8, 2024
@bitsandfoxes bitsandfoxes added the Bug Something isn't working label Apr 8, 2024
@wildlight-sam
Copy link

Is there a still a plan to address this? I just ran into this issue and it's preventing me from configuring the alert setup that I want. Would love to see this fixed so that I don't have to use a subpar workaround.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 May 17, 2024
@bitsandfoxes
Copy link
Contributor

Thanks for bringing this back up. Sorry, I lost track of it and will update here accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Todo
Status: No status
Archived in project
Development

No branches or pull requests

8 participants