Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Awake auto-instrumentation quality #1855

Open
bitsandfoxes opened this issue Oct 21, 2024 · 0 comments
Open

Improve Awake auto-instrumentation quality #1855

bitsandfoxes opened this issue Oct 21, 2024 · 0 comments

Comments

@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented Oct 21, 2024

Currently, when opted-into, the SDK will auto-instrument awake calls.

Issue 1

This can get quite noisy. See 109 Awake instances within Trace View and that is just with 2 MonoBehaviours on each GameObject.
A possible solution would be to group all auto-instrumented awake calls together.

Image

Issue 2

This follows Issue 1. Creating a manual span inside Awake causes it be be the parent of all subsequent Awake calls. See here and here.
If awake calls are already grouped together then there is no need to have them look up GetSpan to set the parent but they could refer to their "fixed" parent.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant