Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release CI completes without the test suite #1844

Closed
bruno-garcia opened this issue Oct 14, 2024 · 4 comments
Closed

Release CI completes without the test suite #1844

bruno-garcia opened this issue Oct 14, 2024 · 4 comments

Comments

@bruno-garcia
Copy link
Member

Release 2.2.1 went out.
The release/2.2.1 branch didn't seem to run the tests:

https://github.com/getsentry/sentry-unity/actions/runs/11335211101

Image

@bruno-garcia
Copy link
Member Author

Seems related to:

The release with version version has the full CI run:

The release with release/version doesn't:

Also note the two different bots involved

@bitsandfoxes
Copy link
Contributor

For context: This was done intentionally. The idea was: If main is green it should not take two hours for a release to go through. But as the team is growing we should rethink such a "by convention" processes.

@bitsandfoxes bitsandfoxes changed the title CI completes without the test suite Release CI completes without the test suite Oct 16, 2024
@bruno-garcia
Copy link
Member Author

For context: This was done intentionally. The idea was: If main is green it should not take two hours for a release to go through. But as the team is growing we should rethink such a "by convention" processes.

I see, that makes sense. But do we have safeguards to make sure the build from the branch (not just main) that we're releasing from is green and hence the release build doesn't need CI?

Also, even package validation doesn't run? If we make any mistake during the release flow (bumping versions, etc) no visibility

@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented Oct 21, 2024

Also, even package validation doesn't run?

Build and Package Validation are part of the Release run.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants