Hook to bundle tasks during Android export for symbols upload #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
approved these changes
Jun 17, 2024
| @@ -87,6 +87,13 @@ private string _symbolUploadTaskFormat | |||
| stringBuilder.AppendLine(string.Empty); | |||
| stringBuilder.AppendLine("tasks.assembleDebug.finalizedBy sentryUploadSymbols"); | |||
| stringBuilder.AppendLine("tasks.assembleRelease.finalizedBy sentryUploadSymbols"); | |||
|
|
|||
| if (_isExporting) | |||
There was a problem hiding this comment.
Is _isExporting the correct condition for this? I thought this was related to .aab and not just the export of the Gradle project itself.
There was a problem hiding this comment.
Only if the user is exporting Android project, we need to add the additional hook for the bundle task.
Otherwise, the assemble task hook works whether .aab or .apk is built from Unity
Co-authored-by: Stefan Jandl <[email protected]>
|
@bitsandfoxes @munkiki7 thank you very much for working on this! When do you expect it to be released? |
Tomorrow at the latest! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1673
Previously, we were binding to the assemble tasks that get executed during Unity build (regardless of whether it is apk or abb).
But for the exported projects .aab artifacts are only created using the bundle task, during which the upload symbol task was not executed.