-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging message is unrendered on a webhook call #3660
Comments
@pohmelie can you paste the output of this 'View Json' from one of those message events from your Sentry instance. I'm interested in what this |
@sl0thentr0py |
@pohmelie Would you be able to post the entire JSON? That would help me determine whether this problem originates in the SDK or the self-hosted backend. FWIW, I was not able to reproduce this with the latest Sentry SDK version and SaaS Sentry. |
Thanks @pohmelie, the JSON would indeed suggest this is an SDK problem. Could you try upgrading to the latest version of Sentry SDK, and let me know whether that works? |
@szokeasaurusrex same with 2.17.0 |
Thanks for the info. I was able to reproduce the issue; seems like it only occurs when a non- # This is rendered correctly
logger.warning("%s", "None")
# This is not rendered
logger.warning("%s", None) |
We will continue investigating; I am unsure whether this problem is occurring in the SDK or elsewhere in the pipeline |
How do you use Sentry?
Self-hosted/on-premise
Version
2.9.0
Steps to Reproduce
We updated self hosted sentry to version 24.8.0 and after that logging integration do not render logging message. So we have a template in a sentry web-ui and webhook call instead of rendered message. For exampe:
This leads to 2 messages in sentry:
task for news source %s returned empty result %s
[debug] task for news source binance_api_changelog_spot returned empty result None
So, only force-rendered via f-string message is correct. Not sure if it is relative to sentry python sdk, or self-hosted sentry itself. Previous version 23.x.x was correct for this. More to say, some messages are rendered correctly. For example with
%d
. In the example abovenews_source
isStrEnum
andresult
isNone
.Expected Result
Actual Result
The text was updated successfully, but these errors were encountered: