-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore_transactions
option should support regular expressions
#1560
Comments
A transaction name should not contain any variables and should instead be fully parameterized. Like Hence I can't entirely agree with the sentiment that this option is useless, especially as our Laravel and Symfony SDKs set a parametrized transaction name by default. |
I see, I was unaware that the transaction name contains placeholders. I'm using sentry-symfony so presumably this is already the case there. In that case I think you can close this. Thank you for explaining! |
I'll leave this open, as I agree with you that having regex support for I personally prefer these options to be explicit, but supporting both ways is definitely a nice-to-have feature. |
I'd recommend adding a note to the documentation of |
Yep, I can take a look and improve the docs around this. |
Problem Statement
Currently
ignore_transactions
option is useless for anything but the most simplest cases such asGET /health
. Any URLs with a variable somewhere in the path (typically an id or slug) can't be ignored using this option. The option was added to remove the need of fiddling with TracesSampler or BeforeSendProcessor but in these cases custom modifications of one of those are still necessary.Solution Brainstorm
In my opinion the
ignore_transactions
option should support regular expressions for the provided URLs.The text was updated successfully, but these errors were encountered: