Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiles_sampler option similar to traces_sampler #1551

Open
cleptric opened this issue Jun 19, 2023 Discussed in #1550 · 0 comments
Open

Add profiles_sampler option similar to traces_sampler #1551

cleptric opened this issue Jun 19, 2023 Discussed in #1550 · 0 comments
Assignees

Comments

@cleptric
Copy link
Member

cleptric commented Jun 19, 2023

Discussed in #1550

Originally posted by tadz June 19, 2023
As of v3.15.0 there is an option config profiles_sample_rate and it's value is relative to traces_sample_rate.
I am able to define transactions that have different traces_sample_rate by defining traces_sampler function.
I want to be able to define profiles_sample_rate in same manner by providing profiles_sampler function.

Example:
I've defined traces_sampler to return 0.1 for all transactions (default)
I've defined profiles_sample_rate to return 0.01

I've defined traces_sampler to return 0.0001 for transactionA and transactionB
I want to define profiles_sample_rate to return 1.0 for transactionA and transactionB to send same amount of profiles as traces

these transactions are manually triggered with startTransaction so for now I'll use init function with new options but it would be better to define that as profiles_sampler function


We already added the option to Python, so let's also add it to PHP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants