Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve minidump Integrations (SentryMinidump, ElectronMinidump) #1009

Open
kpujjigit opened this issue Oct 31, 2024 · 1 comment
Open

Improve minidump Integrations (SentryMinidump, ElectronMinidump) #1009

kpujjigit opened this issue Oct 31, 2024 · 1 comment

Comments

@kpujjigit
Copy link

Problem Statement

The SentryMinidump integration can invoke beforeSend or ignoreErrors at the time of crash, but can't send Main thread mindumps until the crashed application is restored, meaning users who do not restart their app will not send a minidump (Link). ElectronMinidump can send Main thread minidumps right away, but can't invoke beforeSend or ignoreErrors at the time of the crash.

Solution Brainstorm

Currently there isn't a way to both a) capture Main thread minidumps and send right away, AND b) allow callback methods to be invoked before sending to Sentry. Allowing one or both Mindiump integrations for Electron would ensure crashes are sent to Sentry while being subject to callback methods.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Oct 31, 2024
@timfish
Copy link
Collaborator

timfish commented Oct 31, 2024

The sentryMinidumpIntegration works by disabling server upload in Electrons crashReporter. The crashReporter then leaves us to manage the minidump files in a directory.

The electronMinidumpIntegration leaves the crashReporter with server upload enabled and Electrons native crash reporter manages the files. They are often not on disk long enough to be read from JavaScript.

These two modes can't be used together because they both rely of having complete control of the generated minidumps files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants