fix(autofix): Handle empty messages and move cleaning calls inside LLMClient #1484
+32
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennmueng
reviewed
Nov 21, 2024
src/seer/automation/agent/client.py
Outdated
Comment on lines
535
to
542
| @staticmethod | ||
| def clean_tool_call_assistant_messages(messages: list[Message]) -> list[Message]: | ||
| def clean_tool_call_assistant_messages(self, messages: list[Message]) -> list[Message]: |
There was a problem hiding this comment.
If this is not using self and is still used outside the class, would it be not cleaner to just keep it static?
There was a problem hiding this comment.
Made them static now because they don't leverage self, but currently they are not used outside of this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean_tool_call_assistant_messagesinsidegenerate_structuredandgenerate_textso that we don't have to think about cleaning memory when using the LLMClientFixes #1483