Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limit profiles when transaction was sampled #4280

Open
jjbayer opened this issue Nov 22, 2024 · 0 comments · May be fixed by #4195
Open

Rate limit profiles when transaction was sampled #4280

jjbayer opened this issue Nov 22, 2024 · 0 comments · May be fixed by #4195
Labels
filler Requires little effort to resolve. Ready to be picked up anytime.

Comments

@jjbayer
Copy link
Member

jjbayer commented Nov 22, 2024

When a transaction is dropped by dynamic sampling, the profile lives on without the transaction. However, such a profile does not get dropped by rate limits.

This draft PR contains a test that demonstrates the desired behavior: #4195
@jjbayer jjbayer linked a pull request Nov 22, 2024 that will close this issue
Draft
@olksdr olksdr added the filler Requires little effort to resolve. Ready to be picked up anytime. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
filler Requires little effort to resolve. Ready to be picked up anytime.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(profiles): Rate limit profiles when transaction was sampled getsentry/relay
2 participants
@jjbayer @olksdr