Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to rate limit the number of attachments #4175

Open
4 tasks
jjbayer opened this issue Oct 24, 2024 · 0 comments
Open
4 tasks

Add ability to rate limit the number of attachments #4175

jjbayer opened this issue Oct 24, 2024 · 0 comments

Comments

@jjbayer
Copy link
Member

jjbayer commented Oct 24, 2024

Attachment quotas and rate limits are currently defined in bytes, so we have no way to prevent an abusively high number of very small attachments.

Instead of introducing yet another data category for attachment items, we should attempt to rethink quota definitions:

We have a couple of cases now where we'd actually like to track several stats per data category. So the category is "attachment", but the stats we track are: count, cumulative size. Or category is "span" but the stats we track are: received count, stored count. Category is "bucket", stats are: count, cardinality (that's an odd one).

Relay

Sentry

ref: INC-928 > IA-61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant