Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No scoping due to missing project ID #3651

Open
jjbayer opened this issue May 27, 2024 · 3 comments
Open

No scoping due to missing project ID #3651

jjbayer opened this issue May 27, 2024 · 3 comments
Assignees

Comments

@jjbayer
Copy link
Member

jjbayer commented May 27, 2024

See

POP-RELAY-31Z

This is related to #3553, but not the same, because the failure happens before aggregation.

Started happening around May 15th.

@jjbayer
Copy link
Member Author

jjbayer commented May 27, 2024

There's a bad assumption in here somewhere:

see the error
  => state_value() missing
    => contradiction! `merge_buckets_into_aggregator` would not even be called
  OR
  => project_id is none
    => project is invalid or disabled
      => contradiction! we call check_disabled in both code paths leading to the error
    OR
    => project is expired
      => contradiction! project_id wouldn't be none

@jjbayer jjbayer self-assigned this May 28, 2024
@olksdr olksdr assigned Dav1dde and unassigned jjbayer Jun 3, 2024
@Dav1dde
Copy link
Member

Dav1dde commented Jun 3, 2024

I am making a few changes to how metrics work this should fix this issue as well.

@Dav1dde Dav1dde assigned jjbayer and unassigned Dav1dde Jun 24, 2024
@Dav1dde
Copy link
Member

Dav1dde commented Jun 24, 2024

There are project cache changes coming from @jjbayer which should address this issue. My changes did not touch this part of the code, only surrounding parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants