Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse & scrub lowercase redis commands #3643

Open
jjbayer opened this issue May 24, 2024 · 0 comments
Open

Parse & scrub lowercase redis commands #3643

jjbayer opened this issue May 24, 2024 · 0 comments
Labels
bug Something isn't working filler Requires little effort to resolve. Ready to be picked up anytime.

Comments

@jjbayer
Copy link
Member

jjbayer commented May 24, 2024

Not all redis integrations send uppercase redis commands, which results in redis spans being scrubbed as *. See

// NOTE: this should return `DEL *`, but we cannot detect lowercase command names yet.
assert_eq!(scrubbed.0.as_deref(), Some("*"));

Solution: Either use a proper redis parser or allowlist some of the most common commands (get, set, evalsha, ...).

@olksdr olksdr added bug Something isn't working filler Requires little effort to resolve. Ready to be picked up anytime. labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working filler Requires little effort to resolve. Ready to be picked up anytime.
Projects
None yet
Development

No branches or pull requests

2 participants