-
-
Notifications
You must be signed in to change notification settings - Fork 148
Do you support github.com/pkg/errors stacktrace ? #88
Comments
Hello! Here is the code I plan to use. If we want to integrate it to
By the way, I also fixed:
|
@pierrre is definitely right on this issue, if we don't have a good stacktrace on Sentry, it's completely useless to use it or to pay for it since you can't investigate properly with the stacktrace shown on Sentry. @mattrobenolt are you planning to support |
FYI, the latest version of my wrapper:
|
Super thanks @pierrre I've updated your code to provide root error to Sentry instead. This allows the issue title to reflect the correct error type, e.g. https://gist.github.com/choonkeat/f6d45c31ff4e9f84cdfb9c1c0d54f1de
|
@choonkeat thank you ! :) BTW, I just saw this https://docs.google.com/presentation/d/1Wcblp3jpfeKwA0Y4FOmj63PW52M_qmNqlQkNaLj0P5o/edit#slide=id.g1b2157b5d1_3_229 |
@choonkeat actually, I disagree
If you call Edit: Maybe I'm wrong, because Edit2: OK, with my current code, the packet and exception messages are the same. |
@pierrre My bad, didn't notice the "message". I've modified the gist to perform |
+1 this would be really useful |
Note that there is pkg/errors#113 open that would help getting access to the stack frames! |
We're using CapturePanicAndWait and CaptureErrorAndWait so we couldn't use the gist or the fork mentioned above. We worked around it just now by getting the stack trace and sending it via CaptureMessage - not ideal but works for us until Sentry supports github.com/pkg/errors
|
Go SDK is now "error-package-agnostic" due to 238ebd8 |
Im using the master branch but my stack traces are still not good. My stack traces only include the line of the code that is calling capture error. :( e.g.
my stack trace is always
eg of code calling this method
This is really annoying as almost all my events are merged into 1 even tho none of the errors/events have nothing to do with each other only that the stack trace is the same. Does this have to do with the fact that im using a dockerized go binary without the source code? |
I don't understand how the current code can work.
I don't see anything like that in |
@pierrre does #88 (comment) still work ? If it does than I would have to look into using it. Its a shame that the actual SDK doesn't work :( |
This code should still work, but I've updated it to use the new |
@pierrre Thanks! Your wrapper is providing me with stack traces! Thanks a lot :) |
In go, errors don't have a stacktrace.
Errors reported with Sentry/raven-go show the stacktrace of the
Capture
call, instead of where the errors come from.The
github.com/pkg/errors
package adds stack trace to Go errors. (you must wrap all errors witherrors.Wrap
)I don't think you currently support the stacktrace format of this package.
Do you plan to support it?
The text was updated successfully, but these errors were encountered: