From 035c934c3e212d3de5b3e29b042cb9ce9c6f0e25 Mon Sep 17 00:00:00 2001 From: eyelidlessness Date: Fri, 19 Jul 2024 14:05:22 -0700 Subject: [PATCH] JSDoc @todos on current/instance expression predicates reference grammar MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This corrects the previous copypasta mistake, and makes the notes more general so they don’t overly influence reasoning about the gap in behavior --- packages/xforms-engine/src/parse/xpath/semantic-analysis.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/xforms-engine/src/parse/xpath/semantic-analysis.ts b/packages/xforms-engine/src/parse/xpath/semantic-analysis.ts index 68255708..a0d3fcd0 100644 --- a/packages/xforms-engine/src/parse/xpath/semantic-analysis.ts +++ b/packages/xforms-engine/src/parse/xpath/semantic-analysis.ts @@ -114,7 +114,7 @@ const isCurrentFunctionCall = (syntaxNode: FunctionCallNode): boolean => { * - `current()/...` (where `...` represents additional steps) * - `current()//...` (^) * - * @todo XPath grammar technically also allows for `current()[some-predicate]`, + * @todo XPath grammar technically also allows for FilterExpr[Predicate], * and our `tree-sitter-xpath` grammar/parser also allow for this. But * `@getodk/xpath` types do not currently acknowledge this possibility. */ @@ -144,7 +144,7 @@ const isInstanceFunctionCall = (syntaxNode: FunctionCallNode): boolean => { * - `instance("id")/...` (where `...` represents additional steps) * - `instance("id")//...` (^) * - * @todo XPath grammar technically also allows for `current()[some-predicate]`, + * @todo XPath grammar technically also allows for FilterExpr[Predicate], * and our `tree-sitter-xpath` grammar/parser also allow for this. But * `@getodk/xpath` types do not currently acknowledge this possibility. */