Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch URLs under same subdomain as main URL #233

Open
yeahsid opened this issue May 25, 2021 · 4 comments
Open

Branch URLs under same subdomain as main URL #233

yeahsid opened this issue May 25, 2021 · 4 comments
Labels
enhancement Improvement of an existing feature feature New feature

Comments

@yeahsid
Copy link

yeahsid commented May 25, 2021

Currently, branches are created as a subdomain to the main website [website.meli.com , latest.website.meli.com]. Adding support for branch URLs like latest-website.meli.com will allow the use of a single wildcard subdomain instead of adding new ones for every project.
@yeahsid yeahsid changed the title branch URLs under same subdomain as main URL Branch URLs under same subdomain as main URL May 25, 2021
@gempain
Copy link
Contributor

gempain commented May 25, 2021

@itsezsid thanks for suggesting this ! It was actually on our backlog but I need to move some issues from our Trello to Github. I'd love to this see this in the coming releases, it's a really annoying limitation. When we started Meli, we thought this made sense, but we'll be moving branch domains up one level. The only thing I'm worried about is how we're going to prevent collisions (someone naming a site latest-mysite would cause conflicts with someone shipping branch latest on site mysite).

@gempain gempain added enhancement Improvement of an existing feature feature New feature labels May 25, 2021
@gempain
Copy link
Contributor

gempain commented May 25, 2021

@pimartin suggested to avoid conflicts we use a special character (e.g. - or _) and we prevent its use in site names. This way it'll be impossible to have collisions.

@yeahsid
Copy link
Author

yeahsid commented Jun 8, 2021

Ah okay, that would make a lot of sense.

@MrLemur MrLemur mentioned this issue Aug 13, 2021
Open
@mtiller
Copy link

mtiller commented Feb 2, 2022

I wanted to mention here (and relevant for #238 as well) that I'm running Meli using a Kubernetes Helm chart and I've found a workaround for this issue. It is a mildly annoying, but not that bad. Basically, I have an option to list in my values.yaml file all the subdomains that Meli is aware of (i.e., list all the sites). When I do this, the Ingress template creates not only all the necessary wildcard routes but it also requests (via cert-manager in my case) all the wildcard SSL certificates. So as long as I list all my sites in my values.yaml file, I can use the branching features just fine.

@mtiller mtiller mentioned this issue Feb 2, 2022
Closed
mt35-rs added a commit to mtiller/meli that referenced this issue Feb 2, 2022
@mt35-rs
Adds a helm chart
e184f5b 
This commit includes a helm chart or Meli.  I created it based on the
k8s manifest contributed by @Berndinox.  Hopefully that `values.yaml`
file I provided sufficiently explains the various knobs to turn.  One
potential area of improvement would be allowing existing PVCs to
be used.

Note that this includes the feature I mentioned in getmeli#233 but which
also applies to getmeli#238 which is the ability to explicitly list all sites
so that the ingress configuration can fetch SSL certificates
_for branch host names_.

Ideally, this helm chart would be packaged up and shared...somewhere.
I'm actually not that well versed in how to host helm charts for
open source software.  I know there used to be a public registry
hosted by Google but then they withdrew support and the
landscape got very fragmented.  If there _is_ a place to host such
a chart, it would be good to publish this there so that an ordinary
helm installation could reference it.

Not that the `values.yaml` file include the image and tag.  This
can be customized to run a custom Meli image instead of the
official Docker hub image.

This closes getmeli#246.
mt35-rs added a commit to mtiller/meli that referenced this issue Feb 2, 2022
@mt35-rs
feat(k8s): Adds a helm chart
b8acdee 
This commit includes a helm chart or Meli.  I created it based on the
k8s manifest contributed by @Berndinox.  Hopefully that `values.yaml`
file I provided sufficiently explains the various knobs to turn.  One
potential area of improvement would be allowing existing PVCs to
be used.

Note that this includes the feature I mentioned in getmeli#233 but which
also applies to getmeli#238 which is the ability to explicitly list all sites
so that the ingress configuration can fetch SSL certificates
_for branch host names_.

Ideally, this helm chart would be packaged up and shared...somewhere.
I'm actually not that well versed in how to host helm charts for
open source software.  I know there used to be a public registry
hosted by Google but then they withdrew support and the
landscape got very fragmented.  If there _is_ a place to host such
a chart, it would be good to publish this there so that an ordinary
helm installation could reference it.

Not that the `values.yaml` file include the image and tag.  This
can be customized to run a custom Meli image instead of the
official Docker hub image.

This closes getmeli#246.
@mtiller mtiller mentioned this issue Feb 2, 2022
Merged
gempain pushed a commit that referenced this issue Feb 2, 2022
@mtiller @mt35-rs
feat(k8s): Adds a helm chart (#248)
8a731eb 
This commit includes a helm chart or Meli.  I created it based on the
k8s manifest contributed by @Berndinox.  Hopefully that `values.yaml`
file I provided sufficiently explains the various knobs to turn.  One
potential area of improvement would be allowing existing PVCs to
be used.

Note that this includes the feature I mentioned in #233 but which
also applies to #238 which is the ability to explicitly list all sites
so that the ingress configuration can fetch SSL certificates
_for branch host names_.

Ideally, this helm chart would be packaged up and shared...somewhere.
I'm actually not that well versed in how to host helm charts for
open source software.  I know there used to be a public registry
hosted by Google but then they withdrew support and the
landscape got very fragmented.  If there _is_ a place to host such
a chart, it would be good to publish this there so that an ordinary
helm installation could reference it.

Not that the `values.yaml` file include the image and tag.  This
can be customized to run a custom Meli image instead of the
official Docker hub image.

This closes #246.

Co-authored-by: Michael Tiller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature feature New feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtiller @gempain @yeahsid