Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ukrainian translation of YDKJS Yet 2nd Edition #1719

Open
Croftyland opened this issue Jan 5, 2021 · 4 comments
Open

Ukrainian translation of YDKJS Yet 2nd Edition #1719

Croftyland opened this issue Jan 5, 2021 · 4 comments

Comments

@Croftyland
Copy link

Hello, Kyle.

We are a Ukrainian non-profit educational community Kottans. We have translated "Get Started" 2nd edition of YDKJSY into Ukrainian and are working on a translation of book 2.

We kindly ask you to allow us to publish this translation in our organization's repo) (with an appropriate link to your repo). Our work of 1st round review has been done and has received positive feedback from our community.

In addition, it would be great if our work could be merged to your repo as the Ukrainian edition.

Also, we know that sadly further books of the series will not be updated, but we would like to translate 1st edition of those books as well.

Thanks in advance!

@getify
Copy link
Owner

getify commented Jan 5, 2021

Thanks for your inquiry, and appreciate the work you've done on translation. The process for handling (free) foreign language translations is this:

  1. I have now created a branch to host your 2nd-ed translations: https://github.com/getify/You-Dont-Know-JS/tree/2ed-uk

  2. Please submit a pull request against that branch to add your first book translation.

  3. Do the same once you have the second book complete.

  4. Once both of those are complete, I will make you a maintainer of this repository so you can manage any further updates to your own branch.

  5. For future 1st-edition translations, we'll create another branch (forked off the 1st-ed branch) for that work. You'll already be a maintainer at that point, so you'll be able to manage those merges yourself.

  6. But I do ask that you only post completed translations one book at a time, rather than in-progress work. Use your own repositories for the in-progress work for each title, and then do a single PR/merge per book, to keep down the notification noise on this repository.

@Croftyland
Copy link
Author

Thank you so much for your answer!

Is it possible to leave our works in our repo?

@getify
Copy link
Owner

getify commented Jan 5, 2021

Once they are complete/official, I would prefer they reside in this repo (since it's a central location where everybody comes for these books), just as the other foreign language translations have been done. In other words, once it's complete, the version here becomes the main copy.

Of course, that doesn't prevent you from having additional copies/forks elsewhere, but I would prefer this repository hold the main one.

@Croftyland
Copy link
Author

Okay, no problem.

Thanks for your answers

getify added a commit that referenced this issue Jan 7, 2021
add book 1 translation into Ukrainian, closes #1719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants