You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think I may have solved the problem of the plugin not working.
Line 192 originally read $post = isset($_POST['data']) ? $_POST['data'] : [];
However, $_POST as received from the form did not contain any element data. I replaced that line with the admittedly simpler
If (isset($_POST)){
$post = $_POST;
}
The plugin now works in my installation. I didn't actually fork the plugin, and so am not sure how to file a PR.
I also reversed email and addComment in the process section of comments.yaml to avoid the problem of receiving an email even though the comment was not saved.
This fix works even without language being set.
The text was updated successfully, but these errors were encountered:
I'm afraid I cannot help you. But let me test the comment function on my own site. I get so few comments that I can never be sure that it still works after upgrading Grav.
Later: you're right, I am not receiving comments from my site and nothing is being saved. I need to check first that email sending works, and will then look elsewhere.
Email works fine.
@Romarain have you raised the question in Discord?
@jeremycherfas Yes, I talked about that. But you know, for third-party plugins, people tend to ignore requests that seem more a consequence of our own config that of the plugin itself.
I think I may have solved the problem of the plugin not working.
Line 192 originally read
$post = isset($_POST['data']) ? $_POST['data'] : [];
However,
$_POST
as received from the form did not contain any elementdata
. I replaced that line with the admittedly simplerThe plugin now works in my installation. I didn't actually fork the plugin, and so am not sure how to file a PR.
I also reversed
email
andaddComment
in the process section ofcomments.yaml
to avoid the problem of receiving an email even though the comment was not saved.This fix works even without
language
being set.The text was updated successfully, but these errors were encountered: