Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that the full @getdnsapi/getdns API has been implemented #18

Open
joelpurra opened this issue Apr 1, 2017 · 0 comments
Open

Verify that the full @getdnsapi/getdns API has been implemented #18

joelpurra opened this issue Apr 1, 2017 · 0 comments
Labels
help wanted

Comments

@joelpurra
Copy link
Collaborator

While writing tests, a few "magic numbers" popped up. Turns out no all @getdnsapi/getdns API constants have been implemented in getdns-node/src/GNConstants.cpp.

  • Might more be missing?
  • How can changes in the @getdnsapi/getdns API -- past or future -- be detected on the code level, so that the "diff" can be implemented in getdns-node?

The closest thing that comes to mind is to diff getdns/src/getdns/getdns.h.in between releases. What the changes actually mean would then be lookup up in the API documentation. Is that enough?
joelpurra added a commit to joelpurra/getdns-node that referenced this issue Apr 2, 2017
@joelpurra
Add missing getdns constants
e9dc09d 
- Constants are pulled from `getdns/src/getdns/getdns.h.in` and `getdns/src/getdns/getdns_extra.h.in`.
- Text strings have not been included yet.
- Version strings etcetera have been skipped for now.
- The rest has been added blindly.
- This should reduce magic number usage and facilitate return code checks.
- Future versions might (reintroduce) javascript level constant exports using ES6 modules.

This relates to getdnsapi#18, but is not a complete solution. Functions, and possibly other things, still need to be checked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joelpurra