chore: migrate internal and keysend columns to be non null #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
force-pushed
the
task-invoice-migration
branch
from
26c69ac to
afaf6fd
Compare
|
I think we would need to set a default? or how does the value now get filled? |
bumi
reviewed
Oct 31, 2023
| Internal bool `json:"-" bun:",nullzero"` | ||
| Keysend bool `json:"keysend" bun:",nullzero"` | ||
| Internal bool `json:"-" bun:",notnull,default:false"` | ||
| Keysend bool `json:"keysend" bun:",notnull,default:false"` |
There was a problem hiding this comment.
they still use nullzero:
https://bun.uptrace.dev/guide/models.html#default
nullzero,notnull,default:false ?
I think if "" (blank) is set then bun converts it to NULL which then uses the default of false.
| ALTER COLUMN keysend SET DEFAULT false; | ||
|
|
||
| ALTER TABLE invoices | ||
| ALTER COLUMN keysend SET NOT NULL; |
There was a problem hiding this comment.
if a default is set, do we then still need a NOT NULL constraint?
There was a problem hiding this comment.
Yes because I've seen the db values go from false to NULL while running integration_tests for some reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #417