Offer to upgrade tests to support a higher version of react-redux #10127
Labels
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
enhancement
Milestone
Description
In our version of MapStore, we are currently using a newer version of
react-redux
, i.e.7.1.3
instead of6.0.0
, because it has a much cleaner syntax.However, this breaks tests, because of the
render
-function fromreact-dom
, which is frequently being used like this:render
does not return anything for stateless components:And apparently, by upgrading to
react-redux 7.x
, some components become stateless.A first step to enable you to upgrade to
react-redux 7.x
and enable us to keep using it would be to rewrite such tests like this:Would you accept a pull request with these changes to the tests?
This does not break compatibility with your current
react-redux
version and might also help with upgrading the tests once you reachReact 18 (where
render
is deprecated entirely).What kind of improvement you want to add? (check one with "x", remove the others)
Other useful information
This concerns the tests for
The text was updated successfully, but these errors were encountered: