Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contacts and distributions as array? #219

Open
pvgenuchten opened this issue Apr 19, 2023 · 1 comment
Open

contacts and distributions as array? #219

pvgenuchten opened this issue Apr 19, 2023 · 1 comment

Comments

@pvgenuchten
Copy link
Contributor

The pattern of having contacts and distributions as key-value pairs is common in mcf. However this pattern is problematic in mdme. the build form from json schema is not able to manage this pattern in json-schema:

"contact": {
            "title": "Contacts",
            "patternProperties": {
                "^.*": {
                    "type": "object",

I wonder if there are other scenario's with the same issue (there is for example the PR with multiple contacts having the same role which is used as unique key).

I understand this is a massive breaking change, but just curious to hear your thoughts.

@pvgenuchten
Copy link
Contributor Author

in this pr i convert from object to array at load and back to object at save.... it works, but less optimal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant