Bank does not update from scratch after removing

[horkko]

Hi,

I've noticed a strange behavior, which is for me not the one expected.
I've started a bank update. The remote site had a new release, so BioMAJ started to download and launched postprocesses. Then, one of my postprocesses failed. I've not been able to restart from a specific point in the workflow, so I've decided to remove the last release and update it again.

$ biomaj-cli.py --remove --bank foo --release x.x

The removal went ok, it was deleted from the disk.

[notify.py:notifyBankAction:41] BANK[foo] - STATUS[True] - UPDATE[False] - REMOVE[True] - RELEASE[x.x]

However, after restarting a new update of the bank, BioMAJ started to launch postprocess which have failed previously, ignoring that the bank has been deleted the step before.
I've look into the db, and the info are still there in production as well as sessions.
Is this a bug?

Thanks

Emmanuel

[osallou]

This a bug,
The remove should have removed related sessions.

Le mer. 9 nov. 2016 13:11, Emmanuel Quevillon [email protected] a
écrit :

Hi,

I've noticed a strange behavior, which is for me not the one expected.
I've started a bank update. The remote site had a new release, so BioMAJ
started to download and launched postprocesses. Then, one of my
postprocesses failed. I've not been able to restart from a specific point
in the workflow, so I've decided to remove the last release and update it
again.

$ biomaj-cli.py --remove --bank foo --release x.x

The removal went ok, it was deleted from the disk.

[notify.py:notifyBankAction:41] BANK[foo] - STATUS[True] - UPDATE[False] - REMOVE[True] - RELEASE[x.x]

However, after restarting a new update of the bank, BioMAJ started to
launch postprocess which have failed previously, ignoring that the bank has
been deleted the step before.
I've look into the db, and the info are still there in production as well
as sessions.
Is this a bug?

Thanks

Emmanuel

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#69, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-gYsYhPNf5f9BCKTziLvJa_OnqX4rgks5q8biHgaJpZM4Ktd_T
.

[osallou]

One question
For the removal, release was not yet in production, as it failed during
postprocess. It was in oending only, right?
Because, looking at code of remove in bank.py, we should not have found a
session for this release, and removal should have failed (see lines from
990 of banks.py)

Le mer. 9 nov. 2016 14:12, olivier sallou [email protected] a
écrit :

This a bug,
The remove should have removed related sessions.

Le mer. 9 nov. 2016 13:11, Emmanuel Quevillon [email protected]
a écrit :

Hi,

I've noticed a strange behavior, which is for me not the one expected.
I've started a bank update. The remote site had a new release, so BioMAJ
started to download and launched postprocesses. Then, one of my
postprocesses failed. I've not been able to restart from a specific point
in the workflow, so I've decided to remove the last release and update it
again.

$ biomaj-cli.py --remove --bank foo --release x.x

The removal went ok, it was deleted from the disk.

[notify.py:notifyBankAction:41] BANK[foo] - STATUS[True] - UPDATE[False] - REMOVE[True] - RELEASE[x.x]

However, after restarting a new update of the bank, BioMAJ started to
launch postprocess which have failed previously, ignoring that the bank has
been deleted the step before.
I've look into the db, and the info are still there in production as well
as sessions.
Is this a bug?

Thanks

Emmanuel

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#69, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-gYsYhPNf5f9BCKTziLvJa_OnqX4rgks5q8biHgaJpZM4Ktd_T
.

[horkko]

Hi,

Honestly I can't remember if it was in production yet or not. The situation was maybe, the release x.x was in production yet, and I've restarted --from-scratch and one postprocess failed. This is probably the reason why I've seen this strange behavior?