Add letter checking for release version

[braffes]

Hi again,

It should be interesting, if the comparison between version works with version which contains letter.

For example, currently I have:

2021-07-02 17:04:09,964 DEBUG [root][MainThread] found a release 4.1a
2021-07-02 17:04:09,964 DEBUG [root][MainThread] compare next release 4.1c
2021-07-02 17:04:09,964 DEBUG [root][MainThread] compare release major,minor,etc. : 4 >? 4
2021-07-02 17:04:09,964 DEBUG [root][MainThread] compare release major,minor,etc. : 1c >? 1a
2021-07-02 17:04:09,964 DEBUG [root][MainThread] compare next release 4.2a
2021-07-02 17:04:09,964 DEBUG [root][MainThread] compare release major,minor,etc. : 4 >? 4
2021-07-02 17:04:09,964 DEBUG [root][MainThread] compare release major,minor,etc. : 2a >? 1a
2021-07-02 17:04:09,964 DEBUG [root][MainThread] compare next release 4.2c
2021-07-02 17:04:09,964 DEBUG [root][MainThread] compare release major,minor,etc. : 4 >? 4
2021-07-02 17:04:09,964 DEBUG [root][MainThread] compare release major,minor,etc. : 2c >? 1a
2021-07-02 17:04:10,070 INFO  [root][MainThread] Workflow:DownloadService:CleanSession
2021-07-02 17:04:10,073 INFO  [root][MainThread] Session:RemoteRelease:4.1a
2021-07-02 17:04:10,073 INFO  [root][MainThread] Session:Release:4.1a
2021-07-02 17:04:10,073 INFO  [root][MainThread] Workflow:Start:download
2021-07-02 17:04:10,074 INFO  [root][MainThread] Workflow:wf_download

As we see, when the version contains letters, the verification doesn't work.

Thanks for you attention,

Brice

[osallou]

More complex to do.
Code was quite simple, comparing ints

Letters should be detected, and compared, in different patterns...

[braffes]

Maybe the following module can do the jobs:
https://packaging.pypa.io/en/latest/version.html

Without a new module, it should be more complicated ...

[osallou]

could be, will investiguate

now, anyway, will not work in all cases, if versions do not follow some patterns

[braffes]

It seems there is an other issue with the current algorithm.

2021-07-05 13:07:28,183 DEBUG [root][MainThread] found a release 2.1.1
2021-07-05 13:07:28,183 DEBUG [root][MainThread] compare next release 2.0.2
2021-07-05 13:07:28,183 DEBUG [root][MainThread] compare release major,minor,etc. : 2 >? 2
2021-07-05 13:07:28,183 DEBUG [root][MainThread] compare release major,minor,etc. : 0 >? 1
2021-07-05 13:07:28,183 DEBUG [root][MainThread] compare release major,minor,etc. : 2 >? 1
2021-07-05 13:07:28,183 DEBUG [root][MainThread] found newer release 2.0.2
2021-07-05 13:07:28,184 INFO  [root][MainThread] Workflow:DownloadService:CleanSession
2021-07-05 13:07:28,185 INFO  [root][MainThread] Session:RemoteRelease:2.0.2
2021-07-05 13:07:28,185 INFO  [root][MainThread] Session:Release:2.0.2

The good algorithm should stop after comparing 0 >?1, but this is not the case.

[osallou]

Hum, need complete recheck of the algo...
Was made quickly for a specific need

[osallou]

Hi, i will be off for some time (holidays), feel frree to submit a pr for this issue meanwhile i you feel so ;-) Else will manage this after my holidays :-) I will follow requests Le lun. 5 juil. 2021 à 13:20, Brice Raffestin ***@***.***> a écrit :

…

It seems there is an other issue with the current algorithm. 2021-07-05 13:07:28,183 DEBUG [root][MainThread] found a release 2.1.1 2021-07-05 13:07:28,183 DEBUG [root][MainThread] compare next release 2.0.2 2021-07-05 13:07:28,183 DEBUG [root][MainThread] compare release major,minor,etc. : 2 >? 2 2021-07-05 13:07:28,183 DEBUG [root][MainThread] compare release major,minor,etc. : 0 >? 1 2021-07-05 13:07:28,183 DEBUG [root][MainThread] compare release major,minor,etc. : 2 >? 1 2021-07-05 13:07:28,183 DEBUG [root][MainThread] found newer release 2.0.2 2021-07-05 13:07:28,184 INFO [root][MainThread] Workflow:DownloadService:CleanSession 2021-07-05 13:07:28,185 INFO [root][MainThread] Session:RemoteRelease:2.0.2 2021-07-05 13:07:28,185 INFO [root][MainThread] Session:Release:2.0.2 The good algorithm should stop after comparing 0 >?1, but this is not the case. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#127 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH2AYQE6XNMZCV473ANQ33TWGIRNANCNFSM47W5CMGQ> .