bug in localinstall.sh leads to css files note found

[bjosel]

When I use the localinstall.sh script to full install the previewers locally on our servers the css files are located in the folder css but the path in the html files is set to lib (line 28). This leads to the css files not being found and some/most previewers not displaying the content correctly.

Possible fix is:

@@ -25,7 +25,7 @@
cat urls_js.txt

echo Downloading local copies of remote CSS files:
-sed -n 's/.<link.href="(http[^"])"./\1/p' .html | sort -u | sed -n 's/^(./)(.)/sed -i \x27s,\0,lib/\2,\x27 .html/p' > replace_css.sh
+sed -n 's/.<link.href="(http[^"])"./\1/p' .html | sort -u | sed -n 's/^(./)(.)/sed -i \x27s,\0,css/\2,\x27 .html/p' > replace_css.sh
sed -n 's/.<link.href="(http[^"])"./\1/p' *.html | sort -u > urls_css.txt
source replace_css.sh
cat urls_css.txt
@@ -67,4 +67,4 @@

[bjosel]

Some previewers use fonts from bootstrap (glyphicons) which have to be installed locally, too.

[qqmyers]

Thanks for the fix. I've added it to the develop branch. If you'd like to propose changes/make a PR for the glyphicons, please do.

[bjosel]

Hi Jim,
this would be a possible patch to add the icon fonts:

--- localinstall_fix.sh	2024-11-27 13:43:36.496655851 +0100
+++ localinstall_fonts.sh	2024-11-27 13:44:13.528100988 +0100
@@ -30,6 +30,14 @@
 source replace_css.sh
 cat urls_css.txt
 
+echo Downloading local copies of remote fonts:
+fonturl=`grep -m 1 https://stackpath.bootstrapcdn.com/ replace_css.sh | cut -d',' -f 2 | sed s,css/bootstrap.min.css,fonts,`
+echo $fonturl/glyphicons-halflings-regular.eot > urls_fonts.txt
+echo $fonturl/glyphicons-halflings-regular.svg >> urls_fonts.txt
+echo $fonturl/glyphicons-halflings-regular.ttf >> urls_fonts.txt
+echo $fonturl/glyphicons-halflings-regular.woff >> urls_fonts.txt
+echo $fonturl/glyphicons-halflings-regular.woff2 >> urls_fonts.txt
+
 if [ ! -d ./lib ]; then
   mkdir ./lib
 fi
@@ -48,6 +56,15 @@
     wget --quiet $url
 done < "../urls_css.txt"
 
+cd ".."
+if [ ! -d ./fonts ]; then
+  mkdir ./fonts
+fi
+cd ./fonts
+while read url; do
+    wget --quiet $url
+done < "../urls_fonts.txt"
+
 cd ..
 
 
@@ -63,6 +80,7 @@
 echo Cleaning Up...
 rm urls_js.txt
 rm urls_css.txt
+rm urls_fonts.txt
 rm replace_js.sh
 rm replace_css.sh

Although I am not sure if the licensing of glyphicons allows for a local download of the icons. This is maybe something that should be sorted before using the patch. If you confirm that there are no legal issues arising I can create a PR.
Regards
Björn

[qqmyers]

Thanks. While I'm not a lawyer, I think it's OK as we're using the subset that is part of bootstrap which is available for free - e.g. according to https://www.w3schools.com/bootstrap/bootstrap_ref_comp_glyphs.asp .