Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Picker Popover: Clear Icon issues #3348

Open
bfintal opened this issue Oct 9, 2024 · 1 comment · May be fixed by #3359
Open

Icon Picker Popover: Clear Icon issues #3348

bfintal opened this issue Oct 9, 2024 · 1 comment · May be fixed by #3359
Assignees

Comments

@bfintal
Copy link
Contributor

bfintal commented Oct 9, 2024

Issues found:

  1. In an icon block, if you open the icon picker by clicking on the icon (in the content area), clicking the clear icon will completely remove the icon. Expected behavior: same behavior when clicking the clear icon from the icon picker when opened from the inspector
  2. In an Icon List Item block, if you open the icon picker by clicking on the bullet, if you have a custom icon already added, clicking the clear icon button will do nothing
@mxkae
Copy link
Contributor

mxkae commented Oct 28, 2024

For item 2,

If the Icon List Block has a custom icon "A", and then I set custom icon "B" for the Icon List Item Block, clicking the clear icon button reverts the icon in Icon List Item Block to the custom icon "A". Is this the expected behavior? or should clicking the clear button still revert back to the default icon?

Screen.Recording.2024-10-28.at.11.29.24.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@bfintal @mxkae and others