Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations on arbitrary parameter fields (security risks?) #56

Open
peterjc opened this issue Aug 26, 2019 · 2 comments
Open

Recommendations on arbitrary parameter fields (security risks?) #56

peterjc opened this issue Aug 26, 2019 · 2 comments

Comments

@peterjc
Copy link
Contributor

peterjc commented Aug 26, 2019

Prompted by peterjc/galaxy_mira#4 I was looking at our best practise documentation, and found it does not talk about allowing arbitrary parameters to be passed to a tool.

Despite the Galaxy framework having default character sanitisers (to block most special characters like semi colon, pipe or back-tick), my understanding is this was discouraged as a potential security hole - i.e. this field will become part of the command line string, so you have to worry about tricks like running subcommands, or ending the intended command early and running some second arbitrary command as well.

@bgruening
Copy link
Member

I agree it is a potential security risk and it is not good for UX imho. What is the reason to do so? Is it because of too many parameters that the tool author does not want to specify in detail?

@peterjc
Copy link
Contributor Author

peterjc commented Aug 26, 2019

Basically that's the reason. It has come up on MIRA (see pull request) and also BLAST, and that's just the examples I can think of from tools that I personally first wrapped. My preference is to add missing arguments as needed (but there are diminishing returns in effort spent and corner case usage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants