Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every tool needs a requirement? #30

Open
bgruening opened this issue Jun 30, 2016 · 6 comments
Open

Every tool needs a requirement? #30

bgruening opened this issue Jun 30, 2016 · 6 comments

Comments

@bgruening
Copy link
Member

I was reviewing the PR from @mvdbeek and @bwlang and saw this:
https://github.com/galaxyproject/galaxy/pull/2554/files#diff-263ae1620291cf7bcd13ac7faf7be5f0R231

Since we are now using conda packages, it is very easy to annotate every tool with perl, python etc. as dependency. I think we should do this and require every tool to have a dependency.

Can anyone think of any tool that does not need a dependency at all?

@hexylena
Copy link
Member

hexylena commented Jun 30, 2016

hmm, would samtools count because it's a galaxy dependency? (I realise that no one should build tools around a built-in lib, but who knows, some people might).

Edit: Or really any other tool that is (reasonably) available on every nix system. cat? md5sum?

@bgruening
Copy link
Member Author

You want to use a fixed version for you tool and independent of the Galaxy version. Especially if you submit jobs from Docker to somewhere.

@hexylena
Copy link
Member

hexylena commented Jun 30, 2016

But for us, probably this makes very good sense. 👍

@jmchilton
Copy link
Contributor

Absolutely - huge (though unofficial) +1 from me. In the next release of planemo planemo lint --conda_requirements will ensure there is at least one requirement. This is very important for building containers for tools.

@peterjc
Copy link
Contributor

peterjc commented Feb 27, 2017

Presumably for otherwise self-contained Perl/Python/Java/... tools consisting of a single script/jar file and its XML wrapper, you'd like there to be an explicit dependency on Perl/Python/Java/...?

@martenson
Copy link
Member

@peterjc I assume that is the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants