Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow for trinotate #5

Open
2 tasks
Eduardo-Alves opened this issue Jun 30, 2016 · 16 comments
Open
2 tasks

Workflow for trinotate #5

Eduardo-Alves opened this issue Jun 30, 2016 · 16 comments
Assignees

Comments

@Eduardo-Alves
Copy link

Eduardo-Alves commented Jun 30, 2016

https://trinotate.github.io

@Eduardo-Alves
Copy link
Author

signalp 4.0 requires a license. we may have to stick with 3.0 which is wrapped already
https://toolshed.g2.bx.psu.edu/repository/browse_repository?id=292389a45f1a238a
I will test loading the db with results from signalp 3.0 today and see if it works.

@bgruening
Copy link
Collaborator

True, this was an issue :(

@lecorguille
Copy link

@bgruening Can we imagine pushing those developments under IUC repo and blacklist them https://github.com/galaxyproject/tools-iuc/blob/master/.tt_blacklist?

@bgruening
Copy link
Collaborator

The new signalp wrappers? Or what do you mean?

@Eduardo-Alves
Copy link
Author

I checked the wrapper and it requires users to install the dependencies themselves. is this the approach we should take with software that requires license?

http://toolshed.g2.bx.psu.edu/view/peterjc/tmhmm_and_signalp

"First install those command line tools you wish to use the wrappers for:

Install the command line version of SignalP 3.0 and ensure signalp is on the PATH, see: http://www.cbs.dtu.dk/services/SignalP/
Install the command line version of TMHMM 2.0 and ensure tmhmm is on the PATH, see: http://www.cbs.dtu.dk/services/TMHMM/
Install the command line version of Promoter 2.0 and ensure promoter is on the PATH, see: http://www.cbs.dtu.dk/services/Promoter"

@lecorguille
Copy link

lecorguille commented Sep 26, 2016

@bgruening Yes

@bgruening
Copy link
Collaborator

I'm very skeptical about the new SignalP version. We are not allowed to distribute it :(
@Eduardo-Alves this also applies for Docker containers, so we can not ship a functional tool inside of this container. We can add documentation to include the binary manually into our container during runtime. But during build time this is not possible. The first solution is not user friendly at all so I would vote for not including this tool in this container :(

@Eduardo-Alves
Copy link
Author

@Eduardo-Alves
Copy link
Author

I found a few alternatives:
sigCleave is part of the emboss https://github.com/galaxyproject/tools-devteam/tree/master/tools/emboss_5
sigHMM (available for non-commercial use -- is this acceptable?) http://share.gene.com/share/zhang.wood.bioinformatics.2003/sighmm/index.html
PredSi (no restrictions) http://www.predisi.de/

PredSi performs best of the three according to the link in my previous post.

Any experience with these software? I need to check if the output is compatible with trinotate.

@bgruening
Copy link
Collaborator

No experience so far. I would avoid all strange licenses like the one from sigHMM. But PredSi sounds nice ... thanks for the research!

@Eduardo-Alves
Copy link
Author

i wrapped PredSi and uploaded to testtoolshed
https://testtoolshed.g2.bx.psu.edu/view/eduardo/predsi/dda118a96cb0

@bgruening
Copy link
Collaborator

Nice this looks good! Do you want to put this into https://github.com/galaxyproject/tools-iuc. I can guide you through this process and help you creating conda dependencies.

@Eduardo-Alves
Copy link
Author

Thank you Björn, please let me know how to do it

Eduardo

On Fri, Sep 30, 2016 at 4:32 PM, Björn Grüning [email protected]
wrote:

Nice this looks good! Do you want to put this into https://github.com/
galaxyproject/tools-iuc. I can guide you through this process and help
you creating conda dependencies.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJUvUZi3LnQV1gRWSZwIQZ-Xf5gMMlg9ks5qvSt-gaJpZM4JBwD5
.

@bgruening
Copy link
Collaborator

@Eduardo-Alves have a look at this example: galaxyproject/tools-iuc#899

You more or less just need to create a PR against https://github.com/galaxyproject/tools-iuc I will review it and we can iterate until it is perfect :)

Thanks a lot!
Bjoern

@lecorguille
Copy link

WIP Trinotate wrapper: galaxyproject/tools-iuc#1030

@Eduardo-Alves
Copy link
Author

Eduardo-Alves commented Apr 8, 2017

Bjoern

I have moved predsi (signal peptide prediction )and two other tools (tmseg and dgpi) to my tools-iuc branch. they are under protein_annotation.

https://github.com/Eduardo-Alves/tools-iuc/tree/master/tools/protein_annotation
https://github.com/Eduardo-Alves/tools-iuc/tree/master/packages/package_predsi_2004_02_13
https://github.com/Eduardo-Alves/tools-iuc/tree/master/packages/package_tmseg_2_2_0
https://github.com/Eduardo-Alves/tools-iuc/tree/master/packages/package_dgpi_2_04

I also created a tools, mergegffs which works similar to trinotate: It loads a protein prediction gff and several annotations: blast, tmhmm, signalp, hmmer to a sqlite database using gffutils as you suggested during GCC2016.

https://github.com/Eduardo-Alves/tools-iuc/tree/master/tools/mergegffs
https://github.com/Eduardo-Alves/tools-iuc/tree/master/packages/package_genomegtftools_1_0 (this is a fork of the python package, I have the authors permission to wrap it and I will do a PR to his python repository with my changes)

The tools are working fine when installed from toolshed but I am getting an error in travis CL since it is using conda resolution only.

https://travis-ci.org/Eduardo-Alves/tools-iuc/jobs/219895680

UPDATE:
I managed to test using shed_test. Found some issues with mergegffs and working on it.

planemo shed_test --shed_target local --owner planemo --no_cleanup --galaxy_root /opt/galaxy/galaxy-app --tool_dependency_dir /opt/galaxy/galaxy-app/database/dependencies

Thank you

Eduardo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants