-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using android studio 3.1 no longer works cardslib. #568
Comments
just WARNING, don't worry about it. WARNING: The option 'android.enableAapt2' is deprecated and should not be used anymore. |
It's not just a warning. In Android Studio 3.1, the project fails to compile with android.enableAapt2=false. |
Next year android.enableAapt2=false won't work. |
I'd like to second this request: Any intention to patch the library to make it compatible? I'd like to continue using this great library. Thanks. |
enableAapt2 was removed from the later versions of Android Studio / Gradle plugin. It's ignored, so AAPT2 is always used regardless of this option. There is no official patch but this patch is helpful: oplarshad/cardslib@ef39a99 |
Hi, Can you please explain to me how to use this fork of the cardslib project (including this patch) ? Thank you in advance |
I just manually applied the diffs from that patch to my local copy of vanilla cardslib. The changes are to fix the compiler errors which you get with AAPT2. This will allow the project to build with AAPT2. Also, not all the changes from that commit are even required. Lots of the changes are actually to remove redundant code, which is a good thing, but not essential for this task of making it work with AAPT2. Changed files where the changes are NOT only to remove redundant code are:
The key changes are |
Thanks for the reply, it gives me hope for my application :) It is this part which is precisely the problem for me, how do you do that, please? Do you have a link to a page explaining how to fork an android project, modify it locally, and reuse it in another local project? Thank you in advance |
@zeldomar Here's a brief summary... Clone the code from github into a folder (e.g. "cardslib") under your root Gradle project Modify your local
Add the dependency to your app-level
Then just manually apply the diffs which I mentioned from GitHub to the cloned code. I apologise if this is still not clear to you, I don't have the capacity to provide more detail than that, maybe you can ask on some forums like StackOverflow etc if things are still not clear. |
I can't no longer use android.enableAapt2=false.
Any intention to patch the library to make it compatible?
Thanks.
The text was updated successfully, but these errors were encountered: