Modernize and secure temp file creation

[pixeebot]

This change replaces the usage of java.io.File#createTempFile with java.nio.file.Files#createTempFile which has more secure attributes.

The java.io.File#createTempFile() method creates a file that is world-readable and world-writeable, which is almost never necessary. Also, the file created is placed in a predictable directory (e.g., /tmp). Having predictable file names, locations, and will lead to many types of vulnerabilities. History has shown that this insecure pattern can lead to information leakage, privilege escalation and even code execution.

Our changes look something like this:

+  import java.nio.file.Files;
   ...
-  File txtFile = File.createTempFile("acme", ".txt");
+  File txtFile = Files.createTempFile("acme", ".txt").toFile();

More reading

• https://cwe.mitre.org/data/definitions/378.html
• https://docs.fluidattacks.com/criteria/vulnerabilities/160/
• create temporary file in directory with secure permissions  apache/druid#11130
• https://owasp.org/www-community/vulnerabilities/Insecure_Temporary_File
• https://nvd.nist.gov/vuln/detail/CVE-2022-41954
• https://www.cvedetails.com/vulnerability-list/cwe-378/vulnerabilities.html

🧚🤖 Powered by Pixeebot

Feedback | Community | Docs | Codemod ID: pixee:java/upgrade-tempfile-to-nio

[pixeebot]

I'm confident in this change, and the CI checks pass, too!

If you see any reason not to merge this, or you have suggestions for improvements, please let me know!

[pixeebot]

Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them!

[pixeebot]

This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know!

You can also customize me to make sure I'm working with you in the way you want.