Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book root not maintained in URL #19

Open
dwhly opened this issue Nov 12, 2013 · 3 comments
Open

Book root not maintained in URL #19

dwhly opened this issue Nov 12, 2013 · 3 comments

Comments

@dwhly
Copy link

dwhly commented Nov 12, 2013

After a few pages, this:
http://oerpub.github.io/sf-demo-book/reader/

Becomes this:
http://oerpub.github.io/6/4%5Buntitled-e674b181-6d52-4d49-b97b-931362ab6625.html%5D!/2/4/28

Bad! :)

@alerque
Copy link

alerque commented Jul 30, 2016

You can fix the part about not maintaining the root path in the HTML for your reader by setting the base path:

<base href="/sf-demo-book/reader/">

Unfortunately this only fixes part of the problem. You also need some way to pass the location fragments back into the reader, and I haven't figured out that part yet.

@fchasen
Copy link
Contributor

fchasen commented Aug 1, 2016

Ek, yes something pretty funky is going on there, I'll take a peak this week.

This angular version of the reader is sadly very out of date. The demo reader here is updated more frequently: https://github.com/futurepress/epub.js/tree/master/reader

I need to move the demo out of the main repo and start to update this one more frequently soon.

@alerque
Copy link

alerque commented Aug 1, 2016

@fchasen This is roughly the issue I asked about it Gitter a day or two ago. Am I reading you right that I should probably not be using this repo at all and instead figure out how to run directly from the epub-js project? I have to real reason to us Angular except this repo seemed like an easier point of entry. If its buggy and out of date in relation to the main project I should probably just figure out how to get that running on a page of my own, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants