New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move OS checks to separate files #6

Open

fabianvf opened this issue Oct 19, 2016 · 0 comments

Labels

Collaborator

fabianvf commented Oct 19, 2016

Rather than checking the OS a bunch of times all over the place, should have variable files that are conditionally loaded based on the OS.

i.e.: yum: name= '{{ "ovirt-engine-appliance" if ansible_distribution == "CentOS" else "rhevm-appliance" }}'

would become

include '{{ ansible_distribution }}'
yum: name='{{ appliance_package }}'

where appliance_package is defined in the 'CentOS.yml' variable file

fabianvf added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment