Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for multiple og properties with the same key #19

Open
fulls1z3 opened this issue Feb 25, 2017 · 4 comments
Open

support for multiple og properties with the same key #19

fulls1z3 opened this issue Feb 25, 2017 · 4 comments

Comments

@fulls1z3
Copy link
Owner

I'm submitting a ... (check one with "x")

[ ] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[X] feature request

Current behavior
@nglibs/meta does support multiple og properties with the same key.

Expected/desired behavior
It should support multiple og properties with the same key.

For example:

<meta property="og:image" content="http://example.com/rock.jpg" />
<meta property="og:image:width" content="300" />
<meta property="og:image:height" content="300" />
<meta property="og:image" content="http://example.com/rock2.jpg" />
<meta property="og:image" content="http://example.com/rock3.jpg" />
<meta property="og:image:height" content="1000" />

Could have been provided by @nglibs/meta

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 2.0.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@fulls1z3 fulls1z3 added this to the v0.2.0-rc.5 milestone Feb 25, 2017
@fulls1z3 fulls1z3 self-assigned this Apr 4, 2017
@fulls1z3 fulls1z3 modified the milestones: v0.2.0-rc.5, v0.4.0-rc.1 Apr 4, 2017
@samvloeberghs
Copy link

Doesn't the knew meta service support that?

@fulls1z3
Copy link
Owner Author

fulls1z3 commented Apr 8, 2017

When @nglibs/meta was initially released, there was no Meta service in the Angular core. As of version 4, they introduced it - and yes, the Meta service from Angular core supports that feature.

For this reason, I branched the repo into two (master and v0.2.x) while the v0.4.x consumes the Meta service from Angular core, the v0.2.x contains these features internally.

However the main thing in @nglibs/meta is, the ability to render page title and meta titles from route definitions - helping separation of different concerns a bit while improving code cleanliness.

@fulls1z3 fulls1z3 added this to the v0.2.0-rc.6 milestone Apr 12, 2017
@fulls1z3 fulls1z3 modified the milestones: v0.2.0, v0.2.0-rc.6 May 2, 2017
@fulls1z3 fulls1z3 removed this from the v0.2.0 milestone Sep 3, 2017
@fulls1z3 fulls1z3 changed the title [enhancement] support for multiple og properties with the same key support for multiple og properties with the same key Sep 16, 2017
@fulls1z3 fulls1z3 added v5 and removed v4 labels Jan 7, 2018
@fulls1z3 fulls1z3 removed the v5 label Apr 16, 2018
@gbertoncelli
Copy link

Right now is there a workaround for this without using direct DOM interpolation in order to being compatible with Angular Universal?

@fulls1z3 fulls1z3 removed their assignment Nov 22, 2019
@fulls1z3
Copy link
Owner Author

@HighSoftWare96 sorry for the delay, had busy times. feel free to fire a PR and i'll approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants