Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spam message during colcon test #23

Open
fujitatomoya opened this issue Sep 25, 2024 · 1 comment
Open

spam message during colcon test #23

fujitatomoya opened this issue Sep 25, 2024 · 1 comment

Comments

@fujitatomoya
Copy link
Owner

we can see Failed to remove /var/log/rcl_logging_syslog directory message comes from the test fixture, those are kinda annoying.
I think we need to check if the directory exits, and the proceed to remove it. same patch could be applied to
https://github.com/ros2/rcl_logging

1: [ RUN      ] LoggingTest.log_file_name_prefix
1: Failed to remove /var/log/rcl_logging_syslog directory
1: [       OK ] LoggingTest.log_file_name_prefix (1000 ms)
1: [ RUN      ] LoggingTest.use_different_facilities
1: Failed to remove /var/log/rcl_logging_syslog directory
1: [       OK ] LoggingTest.use_different_facilities (3003 ms)
1: [ RUN      ] LoggingTest.full_cycle
1: Failed to remove /var/log/rcl_logging_syslog directory
1: [       OK ] LoggingTest.full_cycle (1001 ms)
1: [----------] 3 tests from LoggingTest (5004 ms total)
@fujitatomoya
Copy link
Owner Author

This is on hold, i will set up the github workflow to make sure the PR does not break the test to take the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant