Repair Date Since #616
Closed
Repair Date Since #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if file has correct date
fronzbot
reviewed
Sep 11, 2022
| @@ -338,9 +338,10 @@ def download_videos( | |||
| _LOGGER.info("No videos found on page %s. Exiting.", page) | |||
| break | |||
|
|
|||
| self._parse_downloaded_items(result, camera, path, delay, debug) | |||
| self._parse_downloaded_items( | |||
| result, camera, path, delay, debug, formatted_date) | |||
There was a problem hiding this comment.
Where in the download_videos method is formatted_date set?
There was a problem hiding this comment.
I dont see the problem. It works fine.
| continue | ||
|
|
||
| if created_at < formatted_date: |
There was a problem hiding this comment.
What type is formated_date? Is it the same as created_at? How do you ensure that?
There was a problem hiding this comment.
I think it will work implicite. It works as string also.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within seven days. Thank you for your contributions. |
|
This issue is now being closed due to inactivity. |
|
It fixes the download issue. Only an idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if file has correct date
Description:
Related issue (if applicable): fixes #604
Checklist:
toxrun successfully PR cannot be meged unless tests pass