Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adjust portrait crop logic to work for both character and sim scoring portraits #459

Closed
fribbels opened this issue Jun 27, 2024 · 0 comments

Comments

@fribbels
Copy link
Owner

Motivation

Currently the character scorer & sim scorer portraits have different dimensions, which means the user will have an incorrect crop for one of them (sim scoring)

Goal

Unsure what the fix is yet but we should be able to handle both types of crop

  • Either 1, have two different crop dimensions
  • 2, always make sure the smaller one fits into the bigger one and they both fit in the original image
  • 3, zoom out and make sure it doesn't exceed image bounds
@fribbels fribbels closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant