Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme-freifunk-generic: broken with recent OpenWrt-19.07 #24

Closed
SvenRoederer opened this issue May 10, 2020 · 4 comments
Closed

theme-freifunk-generic: broken with recent OpenWrt-19.07 #24

SvenRoederer opened this issue May 10, 2020 · 4 comments

Comments

@SvenRoederer
Copy link
Contributor

Installing the "theme-freifunk-generic" results in a broken UI using recent LuCI openwrt-19.07 branch (openwrt/luci@39a8290)
Something in the page-menu seems causing the failure
theme-ff_1907

This is very likely caused by the major rewrite of the LuCI-core (use more JS)

For LEDE-1701 branch the theme was working (tested with openwrt/luci@7b230b0):
theme-ff_1701
@SvenRoederer
Copy link
Contributor Author

  • the last change to the package was made nearly a year ago (June 2019; ac16b4a) - fix build after split from LuCI-feed
  • the last general change was made nearly 1,5 years ago (Dec. 2018; 5d90e70) - done during a general fixup of all themes in the openwrt-luci feed
  • the last change exclusively to the package was done nearly 2 years ago (June 2018; c32097d) - just a fix and backports
  • the last feature change was done sometime before the LuCI-buildsystem was reworked in Dec. 2014

So it seems that the theme is not used any more, so let's drop it from the repo.

@SvenRoederer SvenRoederer changed the title theme-freifunk-generic: broken with recent OpenWrt-19-07 theme-freifunk-generic: broken with recent OpenWrt-19.07 May 18, 2020
@andibraeu
Copy link
Member

We have a similar issue with the bootstrap theme in luci, all menu items are missing. Within the admin backend it is working. Maybe it's an issue with the luci-freifunk package?

image

@SvenRoederer SvenRoederer mentioned this issue Jun 21, 2020
Merged
@SvenRoederer SvenRoederer mentioned this issue Sep 6, 2020
Open
SvenRoederer added a commit to SvenRoederer/freifunk-berlin-firmware that referenced this issue Sep 6, 2020
@SvenRoederer
embedded-files: more descriptive on the "freifunk-mod" rendering issue
6f127c0 
* be more descriptive on the issue by referencing the issue (freifunk/openwrt-packages#24)
* link to some resources that can normally accessed via the pages of this mod

relates to freifunk-berlin#808 also
SvenRoederer added a commit to SvenRoederer/freifunk-berlin-firmware that referenced this issue Sep 9, 2020
@SvenRoederer
luci-static/index_user.html: add new file, to work around broken "luc…
01126aa 
…i-mod-freifunk"

the content of the file will be displayed on the index-page of the router.
The provided links giving a hint, how to reach the LuCI-admin interface and some other handy
pages, as it's currently boken (see freifunk-berlin#831).

* referencing issue freifunk/openwrt-packages#24
* relates to freifunk-berlin#808 also
SvenRoederer added a commit to SvenRoederer/freifunk-berlin-firmware that referenced this issue Sep 28, 2020
@SvenRoederer
luci-static/index_user.html: add new file, to work around broken "luc…
ea2038e 
…i-mod-freifunk"

the content of the file will be displayed on the index-page of the router.
The provided links giving a hint, how to reach the LuCI-admin interface and some other handy
pages, as it's currently boken (see freifunk-berlin#831).

* referencing issue freifunk/openwrt-packages#24
* relates to freifunk-berlin#808 also
SvenRoederer added a commit to SvenRoederer/freifunk-berlin-firmware that referenced this issue Sep 28, 2020
@SvenRoederer
luci-static/index_user.html: add new file, to work around broken "luc…
2ec4479 
…i-mod-freifunk"

the content of the file will be displayed on the index-page of the router.
The provided links giving a hint, how to reach the LuCI-admin interface and some other handy
pages, as it's currently boken (see freifunk-berlin#831).

* referencing issue freifunk/openwrt-packages#24
* relates to freifunk-berlin#808 also
@SvenRoederer
Copy link
Contributor Author

We have a similar issue with the bootstrap theme in luci, all menu items are missing. Within the admin backend it is working. Maybe it's an issue with the luci-freifunk package?

@andibraeu There have been multiple issues with the freifunk luci packages (#33, #32, freifunk-berlin/firmware#831). The issue you you mentioning sounds more like freifunk-berlin/firmware#831

@SvenRoederer
Copy link
Contributor Author

historical theme was dropped and replaced by a fork of OpenWrt-2020 theme in PR #30. It's still a lot different from the historical theme, but at least working a a good start for further customization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andibraeu @SvenRoederer