From dfd802abdcd98100d509a6c84014f6854584b8b9 Mon Sep 17 00:00:00 2001 From: Paul Donald Date: Sat, 30 Nov 2024 23:46:07 +0100 Subject: [PATCH] luci-mod-dashboard: partially invert the black SVG in dark mode Signed-off-by: Paul Donald --- .../luci-static/resources/view/dashboard/css/custom.css | 7 +++++++ .../resources/view/dashboard/include/10_router.js | 4 ++-- .../luci-static/resources/view/dashboard/include/20_lan.js | 2 +- .../resources/view/dashboard/include/30_wifi.js | 2 +- 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/css/custom.css b/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/css/custom.css index bf475aa01ecb..594a90bb69c3 100644 --- a/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/css/custom.css +++ b/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/css/custom.css @@ -192,6 +192,13 @@ border-bottom: 1px solid var(--border-color-medium, rgba(0, 0, 0, 0.1)); } +[data-darkmode="true"] { + /* invert black SVG line drawings in dark mode */ + .Dashboard .svgmonotone { + filter: invert(.5); + } +} + /** * Responsive **/ diff --git a/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/10_router.js b/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/10_router.js index 4cc671da5268..639d372e1e08 100644 --- a/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/10_router.js +++ b/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/10_router.js @@ -44,7 +44,7 @@ return baseclass.extend({ 'src': L.resource('view/dashboard/icons/' + icon + '.svg'), 'width': 'router' == type ? 64 : 54, 'title': title, - 'class': 'middle' + 'class': (type == 'router' || icon == 'not-internet') ? 'middle svgmonotone' : 'middle' }), E('h3', title) ])); @@ -320,7 +320,7 @@ return baseclass.extend({ release: { title: _('Firmware Version'), - value: boardinfo.release.description + value: boardinfo?.release?.description } }; diff --git a/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/20_lan.js b/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/20_lan.js index 9f4edce288a8..27ecc0f7bff9 100644 --- a/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/20_lan.js +++ b/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/20_lan.js @@ -40,7 +40,7 @@ return baseclass.extend({ 'src': L.resource('view/dashboard/icons/devices.svg'), 'width': 55, 'title': this.title, - 'class': 'middle' + 'class': 'middle svgmonotone' }), E('h3', this.title) ])); diff --git a/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/30_wifi.js b/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/30_wifi.js index f87131ceac62..2872c6a3e899 100644 --- a/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/30_wifi.js +++ b/modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/30_wifi.js @@ -41,7 +41,7 @@ return baseclass.extend({ 'src': L.resource('view/dashboard/icons/wireless.svg'), 'width': 55, 'title': this.title, - 'class': 'middle' + 'class': 'middle svgmonotone' }), E('h3', this.title) ]));