Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing functions #11

Open
freevryheid opened this issue Mar 30, 2023 · 7 comments
Open

missing functions #11

freevryheid opened this issue Mar 30, 2023 · 7 comments
Assignees

Comments

@freevryheid
Copy link
Owner

I've added the c defs for these. I'll add these when I find time.

@freevryheid freevryheid self-assigned this Mar 30, 2023
@freevryheid
Copy link
Owner Author

still very much a work in progress. development progressing albeit slowly.

@ludnic
Copy link
Collaborator

ludnic commented Apr 11, 2023

I've seen some of the TODOs in the code. I'll try to take on some of these, maybe starting from the chunk functions.

@freevryheid
Copy link
Owner Author

Didn't realize the size of this when starting out :) Given our time constraints I think we're making good progress.

@lucin81 - I appreciate your assistance with this! To prevent duplication of effort, can we do some planning to delegate tasks for development. If you can prepare a list of tests to address and the functions needed for these I can work on the interface functions This will also help with the layout of the test framework - I think we should break these into separate files as is done on the cpp side. Let me know what you think or have other suggestions.

@ludnic
Copy link
Collaborator

ludnic commented Apr 21, 2023

I agree. It's a nice project, I don't mind if it progresses slowly and it makes sense organising more so we make the most of the time spent on it.

It's a good idea, the test driven development works well for this and should also help prioritise the most important/most used functionality. I was planning to follow the C API tests which seem quite comprehensive. Making a full list of the functions needed for each test suite (agree on breaking them) is a sizeable task, so the way I propose to go about it is to do that as we move along. One overall list of tests here, then one issue per test with the details of the functions needed to complete that test.

@ludnic
Copy link
Collaborator

ludnic commented Apr 21, 2023

This is the list (transferred to README.md) of test suites and what we have already implemented. Some of them we might not want and some we might want to prioritise, we can discuss here or in individual issues. Let me know if this is what you had in mind. Here there isn't a full list of functions but it should already give a good idea what APIs are needed for which tests.

@freevryheid
Copy link
Owner Author

Perfect. Please move this checklist to the readme so we provide a progress report on the front page. We'll flesh this out over time. I think we should also aim to implement some of the helper functions in the node and python api's to provide convenience functions along the lines as suggested by you in issue #9.

@ludnic
Copy link
Collaborator

ludnic commented Apr 22, 2023

started creating some of the issues. functions list are auto generated and approximate. but they should capture the large majority of the functions. will probably mix in some types too, so might need some manual cleaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants