Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest node-xmpp-browser.js doesn't work (window.XMPP not set) #115

Open
dborkan opened this issue May 26, 2015 · 1 comment
Open

Latest node-xmpp-browser.js doesn't work (window.XMPP not set) #115

dborkan opened this issue May 26, 2015 · 1 comment

Comments

@dborkan
Copy link
Contributor

dborkan commented May 26, 2015

To replicate, run grunt demos, then load the Chrome Google demo and attempt to login. Login will fail, because window.XMPP is not set. Previous versions of node-xmpp-browser.js included the line window.XMPP = exports, however the latest build no longer includes this even though the version of node-xmpp-client in package.json has not changed.

You can also compare the node-xmpp-browser.js from npnjs (the one compiled into uProxy) with the most recent node-xmpp-browser.js generated here to see the diffs (there are many)

@dborkan
Copy link
Contributor Author

dborkan commented Jun 5, 2015

FYI to work around this issue locally I'm:

  1. Commenting out browserify in the Gruntfile (https://github.com/freedomjs/freedom-social-xmpp/blob/master/Gruntfile.js#L168)
  2. Copying an old version of node-xmpp-browser.js to dist/

If you need to publish something to npmjs, you can commit the Gruntfile.js change (#1 above) to your LOCAL version of master (just local git, not github), then do npm publish. Without doing this npm publish will run grunt test, which will generate the bad node-xmpp-browser.js and all the tests will fail - preventing you from publishing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant