Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail gracefully if a user signs into Firebase twice with the same agent (clientId) #9

Open
dborkan opened this issue Mar 14, 2015 · 0 comments

Comments

@dborkan
Copy link
Contributor

dborkan commented Mar 14, 2015

Fail gracefully if a user signs into Firebase twice with the same agent (clientId). Currently if a the same user signs in twice with the same clientId, messages will get mixed up between the two sign ins and the user may end up in a bad state (e.g. if the first log in signs out, the client will be marked offline even though the 2nd login still thinks it is online).

uProxy can currently work around this by passing a random number as the agent string for each login.

We should fix this by ensuring that a given clientId can only be signed in at one place, either by:

  • Rejecting later login attempts for an already online clientId
  • Allow later login attempts for an already online clientId, but kicking the first login offline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant