Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runic adds double line spacing #18

Closed
KnutAM opened this issue Jul 17, 2024 · 4 comments
Closed

Runic adds double line spacing #18

KnutAM opened this issue Jul 17, 2024 · 4 comments

Comments

@KnutAM
Copy link

KnutAM commented Jul 17, 2024

Nice package!

I'm quite happy with the suggestions from Runic.jl here (especially if #12 would be included).

But for some reason double line spacing is added in docs/make.jl

E.g.

using FerriteMeshParser
using Documenter

+
const is_ci = get(ENV, "CI", "false") == "true"

Simply ran julia -e 'using Pkg; Pkg.activate(;temp=true); Pkg.add(url = "https://github.com/fredrikekre/Runic.jl"); using Runic; exit(Runic.main(ARGS))' -- -i .

(I tried changed all line endings from CRLF to LF, but cannot rule out that this could be an issue still somehow)

@fredrikekre
Copy link
Owner

Xref JuliaGeometry/DelaunayTriangulation.jl#138 (comment)

Probably fixed by JuliaLang/JuliaSyntax.jl#460 and most likely Windows related

@KnutAM
Copy link
Author

KnutAM commented Jul 18, 2024

(I tried changed all line endings from CRLF to LF, but cannot rule out that this could be an issue still somehow

Apparently, this must have been the issue. Can reproduce the behavior only when making sure that docs/make.jl has CRLF line endings, with LF line endings, it works as intended.

I could not test with the proposed fixed, since I couldn't figure out the version compatibility with julia syntax since JuliaSyntax#main is v0.4.6 but Runic.jl requires the released v0.4.8.

Here are minimum reproducers with lf and crlf in case helpful: testfiles.zip

@fredrikekre
Copy link
Owner

Try again with [email protected] and Runic master? Probably have to reset the commit first because Runic will not revert the double lines once they are in the source.

@KnutAM
Copy link
Author

KnutAM commented Jul 23, 2024

Can confirm that it works, ref https://github.com/Ferrite-FEM/FerriteMeshParser.jl/pull/51/files

@KnutAM KnutAM closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants