Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limelight aiming #146

Open
willitcode opened this issue Mar 18, 2024 · 4 comments
Open

Limelight aiming #146

willitcode opened this issue Mar 18, 2024 · 4 comments
Labels
bug Something isn't working enhancement New feature or request needs testing The features present require testing.

Comments

@willitcode
Copy link
Member

Limelight aiming doesn't work. Why? That part needs investigation.

Even once it does work, we should still tweak it—instead of the tx value translating into robot rotation, it should translate into strafing robot movement relative to the amp. Assuming we get heading snapping working, we can use heading snapping to lock the robot's heading into pointing straight towards the amp as well. Theoretically, this should lead to a very efficient aiming routine—assuming that the Limelight's limited FOV doesn't result in us immediately losing sight of the AprilTag. If that happens, we can maybe experiment with using the tx value as input for both strafe and rotation... but that could get weird fast.

@willitcode willitcode added bug Something isn't working enhancement New feature or request labels Mar 18, 2024
@willitcode
Copy link
Member Author

In do later because Heartland branch needs to merge before we can do anything & troubleshooting requires access to a bot that is not in several pieces

@willitcode
Copy link
Member Author

Should theoretically have been fixed by #159. Still needs testing.

@AraReighard AraReighard added the needs testing The features present require testing. label Mar 25, 2024
@willitcode
Copy link
Member Author

idek what is going on with LL aiming anymore... tested a lot at comp, nothing seems to be working. Our best bet at this point may be to use heading snapping to lock ourselves towards the side that the amp is on and then use the limelight to drive forward, back, and side to side... but I'm not sure if that actually works. IIRC we implemented it at comp and it didn't really seem to. We're also having some oscillation issues with the speed multipliers, so we'll see how that goes.

TLDR: needs an absurd amount of testing and me just sitting there trying to figure it out. We probably don't have time for it.

@willitcode
Copy link
Member Author

We should get rid of the logic that automatically ends the command if we lose sight of the target instead of just commenting it out (this is a todo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request needs testing The features present require testing.
Projects
Status: Do Later
Development

No branches or pull requests

2 participants