Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with webpack #441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tagliala
Copy link
Contributor

Add some entries to package.json to improve compatibility with webpack

  • Add import export as per webpack requirements
  • Add style export for CSS file
  • Add *.css to "side effects" to prevent issues with tree-shaking

With this commit, it is possible to import frappe-gantt without breaking changes in webpack-based applications

Refs:

Close #439

Add some entries to `package.json` to improve compatibility with webpack

- Add `import` export as per webpack requirements
- Add `style` export for CSS file
- Add `*.css` to "side effects" to prevent issues with tree-shaking

With this commit, it is possible to import frappe-gantt without breaking
changes in webpack-based applications

Refs:
- https://webpack.js.org/guides/package-exports/

Close frappe#439
@tagliala tagliala force-pushed the chore/import-directive-webpack branch from 0325398 to c88e8fc Compare September 24, 2024 07:44
@tagliala tagliala marked this pull request as ready for review September 28, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v0.8.x]: cannot import in complex webpack-based workflows
1 participant