Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricing Rule is broken on most of Apply Rule On Other options #42195

Open
ruthra-kumar opened this issue Jul 5, 2024 · 2 comments
Open

Pricing Rule is broken on most of Apply Rule On Other options #42195

ruthra-kumar opened this issue Jul 5, 2024 · 2 comments
Assignees
Labels

Comments

@ruthra-kumar
Copy link
Member

ruthra-kumar commented Jul 5, 2024

Pricing Rules where the discount / margin is applied on other item code / item group / brand is broken.

Broken Scenarios:

- Apply On Value Apply Rule on Other Value
1 Item Code Item 1 Item Code Item 2
2 Item Group All Item Group Item Group All Item Group
3 Item Code/Group any_value Brand any_value

On above cases, the discount is applied on the trigger item itself, either on item addition or upon save.

Version

v14 and v15

References:
https://support.frappe.io/helpdesk/tickets/16804
https://support.frappe.io/helpdesk/tickets/17723
https://support.frappe.io/helpdesk/tickets/15810

@ruthra-kumar ruthra-kumar self-assigned this Jul 5, 2024
@ruthra-kumar ruthra-kumar changed the title Pricing Rule is broken on most of 'Apply On Other' options Pricing Rule is broken on all of Apply Rule On Other options Jul 5, 2024
@ruthra-kumar ruthra-kumar changed the title Pricing Rule is broken on all of Apply Rule On Other options Pricing Rule is broken on most of Apply Rule On Other options Jul 5, 2024
@ruthra-kumar
Copy link
Member Author

ruthra-kumar commented Jul 5, 2024

[1]

Rules:
Screenshot from 2024-07-05 13-53-55
Screenshot from 2024-07-05 13-54-11

Discount.on.other.item.mp4

@ruthra-kumar
Copy link
Member Author

ruthra-kumar commented Sep 10, 2024

Handle uom conversion on mixed condition
https://support.frappe.io/helpdesk/tickets/21803

#43166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant