Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add CLI Completion #325

Open
willwill2will54 opened this issue Jun 27, 2024 · 1 comment · May be fixed by #328
Open

Request: Add CLI Completion #325

willwill2will54 opened this issue Jun 27, 2024 · 1 comment · May be fixed by #328
Labels
author-willing-to-impl The author of this issue is willing to try to implement the solution themselves. C-enhancement Category: enhancement tribble-reported This issue was reported through Tribble.

Comments

@willwill2will54
Copy link

This issue is requesting an enhancement to Perseus. Details of the scope will be available in issue labels.
The user described the problem related to this request as follows:

Perseus-cli is missing CLI Completion

The user described the issue as follows:

I would like to request the adding of CLI completion definitions for the perseus-cli tool. Perseus-cli uses clap under the hood, which has functionality for generating completions at run-time or compile-time. Which to do would require discussion, as each has trade-offs.

  • The author is willing to attempt an implementation: true
Tribble internal data

dHJpYmJsZS1yZXBvcnRlZCxDLWVuaGFuY2VtZW50LGF1dGhvci13aWxsaW5nLXRvLWltcGw=

@github-actions github-actions bot added author-willing-to-impl The author of this issue is willing to try to implement the solution themselves. C-enhancement Category: enhancement tribble-reported This issue was reported through Tribble. labels Jun 27, 2024
@arctic-hen7
Copy link
Member

Yes I've been meaning to do this for a while but just haven't gotten around to it! I think compile-time completions sound good unless you see any particular problem with that? I'd be very happy to accept a PR for this.

@willwill2will54 willwill2will54 linked a pull request Jul 4, 2024 that will close this issue
3 tasks
@arctic-hen7 arctic-hen7 linked a pull request Jul 7, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-willing-to-impl The author of this issue is willing to try to implement the solution themselves. C-enhancement Category: enhancement tribble-reported This issue was reported through Tribble.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants