Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sqlalchemy to v2 #972

Closed
tcompa opened this issue Nov 16, 2023 · 3 comments
Closed

Update sqlalchemy to v2 #972

tcompa opened this issue Nov 16, 2023 · 3 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@tcompa
Copy link
Collaborator

tcompa commented Nov 16, 2023

For the moment we are bound to v1 due to sqlmodel, but this may change in the near future.

As of #947, we'll start including comments like

# SQLAlchemy2: use icontains

where we identify changes that would be possible and/or needed when passing from sqlalchemy v1 to v2.
@tcompa tcompa added the dependencies Pull requests that update a dependency file label Nov 16, 2023
@tcompa
Copy link
Collaborator Author

tcompa commented Nov 20, 2023

Now available in sqlmodel 0.0.12: https://sqlmodel.tiangolo.com/release-notes/#0012

@tcompa tcompa linked a pull request Nov 20, 2023 that will close this issue
[DO NOT MERGE] Update to sqlalchemy v2 and sqlmodel 0.0.12 #995
Closed
1 task
@tcompa
Copy link
Collaborator Author

tcompa commented Nov 21, 2023

Ref #1011 (comment)

@tcompa
Copy link
Collaborator Author

tcompa commented Nov 30, 2023

Closed with #1044

@tcompa tcompa closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DO NOT MERGE] Update to sqlalchemy v2 and sqlmodel 0.0.12 fractal-analytics-platform/fractal-server
1 participant
@tcompa